asi-migration preparation #50
Conversation
| @@ -24,7 +24,7 @@ use crate::msg::{ExecuteMsg, InstantiateMsg, QueryMsg, Uint128}; | |||
| use crate::state::{config_read, State}; | |||
|
|
|||
| pub const DEFAULT_OWNER: &str = "Owner"; | |||
| pub const DEFAULT_DENUM: &str = "atestfet"; | |||
| use cosmwasm_std::{entry_point, DepsMut, Env, Response, StdError, StdResult}; | ||
|
|
||
| #[cfg_attr(not(feature = "library"), entry_point)] | ||
| pub fn migrate(deps: DepsMut, env: Env, msg: MigrateMsg) -> StdResult<Response> { |
There was a problem hiding this comment.
For some reason you can't have MessageInfo which contains sender and sent funds during migration
| supply: supply.unwrap_or_else(|_| Uint128::zero()), | ||
| fees_accrued: Uint128::zero(), | ||
| supply, | ||
| fees_accrued, | ||
| next_swap_id: msg.next_swap_id, | ||
| sealed_reverse_swap_id: 0, |
There was a problem hiding this comment.
sealed_reverse_swap_id looks unused, can it be removed?
There was a problem hiding this comment.
Keep it.
I'm not quite seure after these yearsm, but something tells me that was unfinished idea, where some service was suposed to check craop out of evrything, and up to specific reserse_swap_id and if everythign check out, then set the sealed_reverse_swap_id to that reserse_swap_id value, what would mean that all swap ids up to that are 101% checked and so irreversible (non-refundable, etc. ...).
I think it was not implemented, and this is just remnant of that idea.
There was a problem hiding this comment.
I am keeping it, but it will just be always 0. It was always 0 anyway.
| Ok(Response::default()) | ||
| } | ||
|
|
||
| pub fn initialise_contract_state( |
There was a problem hiding this comment.
Maybe it is ok because this migration will be one-time thing, but this means that during migration we will have to set all parameters to contract manually and it will rewrite the original contract State.
One solution would be to keep the legacy state Struct definition, load legacy state value with it and rewrite only parameters we want to change. Or make it to change only denom.
Maybe my implementation is unnecessary too general.
| re_init.supply, | ||
| re_init.relay_eon, | ||
| re_init.fees_accrued, |
There was a problem hiding this comment.
These 3 attributes should be simply read from the current contract state (= no change in their value).
Though we can query those values from the contract and before initialisation and use them in this re_init message, but it kind of feels dangerous, opening the gate to possible mishaps (wrong copy-paste, ors omething like that).
There was a problem hiding this comment.
We are be able to read it from contract state only if legacy contract state is compatible with new contract state or if we keep the original contract state definition for migration sake.
There was a problem hiding this comment.
I've added legacy state handling
fetch/cosmwasm_contract/src/msg.rs
Outdated
| pub supply: Uint128, | ||
| pub relay_eon: u64, | ||
| pub fees_accrued: Uint128, |
MissingNO57
changed the title
atestfet/afettoatestasi/aasicontract_addr_humanfrom Statewipe_all_roles_from_storagefrom access_control