Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params tests #98

Merged
merged 10 commits into from
Jul 15, 2021
Merged

Params tests #98

merged 10 commits into from
Jul 15, 2021

Conversation

Josumner
Copy link
Contributor

Test: add IsAllowedSender and validateAllowList tests

@Josumner Josumner requested a review from ejfitzgerald July 12, 2021 16:42
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #98 (e65f10c) into master (9b3f86e) will increase coverage by 0.04%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   62.90%   62.94%   +0.04%     
==========================================
  Files         631      631              
  Lines       41472    41470       -2     
==========================================
+ Hits        26089    26105      +16     
+ Misses      12987    12967      -20     
- Partials     2396     2398       +2     
Impacted Files Coverage Δ
codec/types/interface_registry.go 63.36% <ø> (ø)
x/airdrop/keeper/grpc_query.go 65.00% <ø> (ø)
x/airdrop/keeper/keeper.go 54.54% <0.00%> (ø)
x/airdrop/keeper/msg_server.go 0.00% <ø> (ø)
x/airdrop/keeper/params.go 100.00% <100.00%> (ø)
x/airdrop/types/genesis.go 80.00% <100.00%> (-3.34%) ⬇️
x/airdrop/types/params.go 84.00% <100.00%> (+72.00%) ⬆️

x/airdrop/keeper/params_test.go Outdated Show resolved Hide resolved
x/airdrop/keeper/params_test.go Outdated Show resolved Hide resolved
x/airdrop/keeper/params_test.go Outdated Show resolved Hide resolved
x/airdrop/keeper/params_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@daeMOn63 daeMOn63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks also good here! Let's drop unused append from Validate and go 👍

x/airdrop/types/genesis.go Outdated Show resolved Hide resolved
@Josumner Josumner merged commit 90b1433 into master Jul 15, 2021
@Josumner Josumner deleted the Params_tests branch July 15, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants