Diff denom keeper tests #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daeMOn63
suggested changes
Jul 9, 2021
x/airdrop/keeper/keeper_test.go
Outdated
| @@ -164,6 +166,84 @@ func (s *KeeperTestSuite) TestFeeDrip() { | |||
| s.Require().Equal(feeCollectorBalance, sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(4040))) | |||
| } | |||
|
|
|||
| func (s *KeeperTestSuite) TestAddNewFundWithDiffDenom() { | |||
| amount := sdk.NewInt64Coin("afet", 4000) | |||
There was a problem hiding this comment.
I'd vote for using another denom that afet here. This is test and can be anything really, no need to create any confusion with prod tokens.
There was a problem hiding this comment.
Yep, good call - let me know what you think of "denom" as a placeholder
x/airdrop/keeper/keeper_test.go
Outdated
| } | ||
|
|
||
| func (s *KeeperTestSuite) TestMultiDenomFeeDrip() { | ||
| amount_stake := sdk.NewInt64Coin(sdk.DefaultBondDenom, 4000) |
There was a problem hiding this comment.
on variable naming, go uses camelCase only.
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 61.99% 63.01% +1.01%
==========================================
Files 622 624 +2
Lines 35762 41382 +5620
==========================================
+ Hits 22170 26076 +3906
- Misses 11239 12910 +1671
- Partials 2353 2396 +43
|
daeMOn63
previously approved these changes
Jul 9, 2021
ejfitzgerald
reviewed
Jul 9, 2021
x/airdrop/keeper/keeper_test.go
Outdated
|
|
||
| fund2 := types.Fund{ | ||
| Amount: &amountStake, | ||
| DripAmount: sdk.NewInt(4000), // will only last one block |
There was a problem hiding this comment.
It would be a slightly better test if we didn't use the same 4000 40 combination but mixed it up a little
ejfitzgerald
previously approved these changes
Jul 9, 2021
|
Sorry guys - my mistake! Accidentally pushed to this before merging and pushing to a new branch |
Josumner
force-pushed
the
diff_denom_keeper_tests
branch
from
1c84c0b to
9e1c039
Compare
daeMOn63
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test fund with afet
Added test drip with stake and afet