fix: file keyring backend key recover error #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
key recover fails with EOF errors when attempting to read keyring password from piped file. This change allows to recover the current `*bufio.Reader` from the context instead of creating a new one, in order to have the mnemonic and password read from the same source. In still require the application to init the context with a `*bufio.Reader` argument to `WithInput(r io.Reader)`.
daeMOn63
force-pushed
the
fix_file_keyring_key_recovery
branch
from
69bd28c to
d543d4b
Compare
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 62.94% 63.06% +0.11%
==========================================
Files 631 631
Lines 41470 41470
==========================================
+ Hits 26105 26154 +49
+ Misses 12967 12909 -58
- Partials 2398 2407 +9
|
daeMOn63
added a commit
that referenced
this pull request
Jul 30, 2021
daeMOn63
added a commit
that referenced
this pull request
Jul 30, 2021
daeMOn63
added a commit
that referenced
this pull request
Aug 2, 2021
* continuation from #106 on other impacted commands: * keys import * keys export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key recover fails with EOF errors when attempting to read keyring
password from piped file.
This change allows to recover the current
*bufio.Readerfrom the contextinstead of creating a new one, in order to have the mnemonic and
password read from the same source.
In still require the application to init the context with a
*bufio.Readerargument toWithInput(r io.Reader).