Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: New currency support, proposal improvements, and fixes #391

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

sh-wallet
Copy link

@sh-wallet sh-wallet commented Aug 26, 2024

Proposed Changes

  1. Proposal improvements
  2. fix: App hanging for at least 2000 ms
  3. Additional analytics
  4. Graph pricing based on selected currency
  5. Additional currencies added
  6. Dynamic currency support throughout the app

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

@sh-wallet sh-wallet self-assigned this Aug 26, 2024
@sh-wallet sh-wallet marked this pull request as ready for review August 30, 2024 06:06
@sh-wallet sh-wallet changed the title Mobile: Improvement and Fixes Mobile: New currency support, proposal improvements, and fixes Aug 30, 2024
@sh-wallet sh-wallet changed the base branch from master to main September 11, 2024 06:15
@sh-wallet sh-wallet enabled auto-merge (squash) September 11, 2024 06:17
@sh-wallet sh-wallet merged commit 8b5814c into main Sep 11, 2024
@sh-wallet sh-wallet deleted the mobile/bug-fixes branch September 11, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants