-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Change of var method for interface discontinuities #904
Draft
RemDelaporteMathurin
wants to merge
39
commits into
festim-dev:fenicsx
Choose a base branch
from
RemDelaporteMathurin:change-of-var-method
base: fenicsx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP Change of var method for interface discontinuities #904
RemDelaporteMathurin
wants to merge
39
commits into
festim-dev:fenicsx
from
RemDelaporteMathurin:change-of-var-method
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemDelaporteMathurin
added
enhancement
New feature or request
fenicsx
Issue that is related to the fenicsx support
labels
Oct 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #904 +/- ##
===========================================
- Coverage 97.49% 95.95% -1.54%
===========================================
Files 44 45 +1
Lines 2193 2398 +205
===========================================
+ Hits 2138 2301 +163
- Misses 55 97 +42 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Dokken/change of var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs #909
This implements the change of variable method we use in FESTIM 1 to handle interface discontinuities.
Example usage: