allowed_meshes property for derived quantities #832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix for #829
This PR proposes to change the approach for knowing if certain quantities are allowed with various systems of coordinates (cartesian, cylindrical, spherical).
Instead of having a long list of allowed quantities for each mesh type in
Simulation.initialise
- which was very hard to maintain -, each quantity now has a property calledallowed_meshes
that is a list of mesh types that this property can be used with.By default, the three mesh types are allowed.
When inheriting from the parent class, it is possible to override this property.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist