Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citation and add missing publications #717

Merged

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This PR just updates the preferred citation and add missing publications to the docs.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (b5035d6) to head (4e1d9d0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files          58       58           
  Lines        2350     2350           
=======================================
  Hits         2338     2338           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to get this in too

docs/source/publications.rst Outdated Show resolved Hide resolved
@RemDelaporteMathurin RemDelaporteMathurin merged commit ef198c5 into festim-dev:main Mar 26, 2024
5 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the update-citation branch March 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants