Upgrade OTel to stop Tokio being pinned #2932
Conversation
Signed-off-by: itowlson <[email protected]>
There was a problem hiding this comment.
I ran this locally and confirmed that traces, metrics, and logs are still correctly coming through 👍.
One oddity is that I'm observing some DEBUG logs that I feel like I shouldn't be seeing:
2024-11-21T16:39:35.806231Z DEBUG opentelemetry_sdk: name="PeriodicReader.ExportTriggered" Export message received.
2024-11-21T16:39:35.821313Z DEBUG opentelemetry_sdk: name="PeriodicReader.ExportTriggered" Export message received.
2024-11-21T16:40:35.805557Z DEBUG opentelemetry_sdk: name="PeriodicReader.ExportTriggered" Export message received.
Investigating ^
| let exporter_builder: LogExporterBuilder = match OtlpProtocol::logs_protocol_from_env() { | ||
| OtlpProtocol::Grpc => opentelemetry_otlp::new_exporter().tonic().into(), | ||
| OtlpProtocol::HttpProtobuf => opentelemetry_otlp::new_exporter().http().into(), | ||
| let exporter = match OtlpProtocol::logs_protocol_from_env() { |
There was a problem hiding this comment.
All these log changes seem correct to me.
| let exporter_builder: MetricsExporterBuilder = match OtlpProtocol::metrics_protocol_from_env() { | ||
| OtlpProtocol::Grpc => opentelemetry_otlp::new_exporter().tonic().into(), | ||
| OtlpProtocol::HttpProtobuf => opentelemetry_otlp::new_exporter().http().into(), | ||
| let exporter = match OtlpProtocol::metrics_protocol_from_env() { |
There was a problem hiding this comment.
Metrics changes also make sense to me.
| let exporter_builder: SpanExporterBuilder = match OtlpProtocol::traces_protocol_from_env() { | ||
| OtlpProtocol::Grpc => opentelemetry_otlp::new_exporter().tonic().into(), | ||
| OtlpProtocol::HttpProtobuf => opentelemetry_otlp::new_exporter().http().into(), | ||
| let exporter = match OtlpProtocol::traces_protocol_from_env() { |
There was a problem hiding this comment.
You also get a ✅ here to 😄
crates/telemetry/src/lib.rs
Outdated
| tracing::trace!(?err, "OpenTelemetry error"); | ||
| } | ||
| } | ||
| // fn otel_error_handler(err: opentelemetry::global::Error) { |
There was a problem hiding this comment.
I'll try to get this working
|
Dumping my stream of consciousness here as I work on this. The errors I'm seeing are b/c of you following the error handler migration guide. |
Signed-off-by: Caleb Schoepp <[email protected]>
|
This should do it @itowlson itowlson#1. Once you have that merged I think this all LGTM. |
Fix OTel error handler migration
@calebschoepp I couldn't figure out how to migrate the custom error handler so I put in as much of their "migration guide" as I could get to compile, and left the commented-out custom handler for now. If you have a moment to take a look and figure out the correct migration, that would be awesome. Thank you so much for offering to pitch in.
The rest of it is my best effort at understanding how the APIs have changed from 0.25 to 0.27, but this really has been a matter of "follow the compiler errors" rather than any genuine understanding. And I have no real way of testing it. So please do read critically and err on the side of flagging anything that isn't obviously right! Thanks!