Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Value re-*factor*ing #2843

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Key Value re-*factor*ing #2843

merged 4 commits into from
Sep 19, 2024

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Sep 18, 2024

Similar in scope to #2840. This is just a refactoring and so only impacts users of the key-value factor library.

  • Removes the idea of a "default" store manager instead relying on runtime config handling to add a store manager for the default label.
  • The "default" store manager is now added directly after runtime config is deserialized from toml.
  • The key-value factor tests are reimagined
    • The tests now try to verify the actual behavior of the factor and not of the runtime config
    • Runtime configuration is now tested in the runtime config crate.

@rylev rylev requested a review from lann September 18, 2024 14:47

use super::*;

/// Define a test factor with the given field and factor type.
macro_rules! define_test_factor {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOO FANCY

@rylev rylev merged commit 31aa7ec into main Sep 19, 2024
17 checks passed
@rylev rylev deleted the key-value-re-factoring branch September 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants