Fix warning from redis crate. #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
approved these changes
Sep 18, 2024
You can read about the warning here: redis-rs/redis-rs#1228 Essentially, the functions in question are subject to a subtle change that will be coming in Rust 2024. To get ahead of this change, a warning is now produced in Rust 1.81. The fix is small even if it's unfortunately a bit awkward. Signed-off-by: Ryan Levick <[email protected]>
rylev
force-pushed
the
fix-new-warning
branch
from
a16b7f1 to
006c8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can read about the warning here: redis-rs/redis-rs#1228
Essentially, the functions in question are subject to a subtle change that will be coming in Rust 2024. To get ahead of this change, a warning is now produced in Rust 1.81. The fix is small even if it's unfortunately a bit awkward.