Replace tempdir with tempfile #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
commented
Aug 26, 2024
| fn run( | ||
| self, | ||
| trigger_app: TriggerApp<Self>, | ||
| ) -> impl Future<Output = anyhow::Result<()>> + Send; | ||
| fn run(self, trigger_app: TriggerApp<Self>) -> impl Future<Output = anyhow::Result<()>> + Send; |
There was a problem hiding this comment.
Sneaky unrelated rustfmts 🕵️
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
lann
commented
Aug 26, 2024
| @@ -312,7 +312,7 @@ impl<T: Trigger> TriggerAppBuilder<T> { | |||
| let use_gpu = true; | |||
| let state_dir = match options.state_dir { | |||
| // Make sure `--state-dir=""` unsets the state dir | |||
| Some(s) if s.trim().is_empty() => None, | |||
| Some("") => None, | |||
There was a problem hiding this comment.
This isn't equivalent, no? Some(" ") would match the first but not the second.
There was a problem hiding this comment.
Ah sorry I blindly obeyed clippy. That said, --state-dir " " seems more likely to be an accident...
There was a problem hiding this comment.
Though it now occurs to me that its perfectly valid to create a directory named " "...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tempdiris abandoned