update node version for integration test #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
force-pushed
the
fix_integration_test
branch
from
148fcb6 to
0b1be45
Compare
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
fix_integration_test
branch
from
0b1be45 to
876131f
Compare
rylev
reviewed
Aug 1, 2024
| prebuild, | ||
| HashMap::default(), | ||
| "Hello from TS-SDK", | ||
| "hello universe", |
There was a problem hiding this comment.
Just curious. Why was this changed?
There was a problem hiding this comment.
I wish I had a better answer than, the first iteration of the SDK started with and it just stuck 😅
There was a problem hiding this comment.
Bit of a shame - I think the previous versions were better, but this isn't the place to discuss that I suppose.
rylev
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.