-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factors trigger #2693
Factors trigger #2693
Conversation
@@ -0,0 +1,30 @@ | |||
[package] | |||
name = "spin-trigger2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
These temporary copies to ease refactoring. Signed-off-by: Lann Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is when things start to get a bit scary - the trigger2 crate has a lot of overlap with the existing trigger crate, and it's hard to see where things differ. I think we're at the point that I'd like to see integration of factors happened as quickly as possible so we stop living in a world where things can easily diverge.
use crate::{server::HttpExecutor, Store, TriggerInstanceBuilder}; | ||
|
||
#[derive(Clone)] | ||
pub struct HttpHandlerExecutor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to document what this is - an HttpExector
that can execute wasi and spin http incoming requests.
Agreed. I've been struggling with a more principled refactor here and at this point I just want to get something merged to build on. |
This turned into a bit of a mega-PR, but I have split out some smaller commits, including:
SpinFilesMounter
FactorsExecutorApp
typeNote that while this mostly a straight port, I have also implemented 2 breaking changes for Spin 3.0:
base
field/
is still permitted with a warningI've left the existing
spin-trigger
andspin-trigger-http
crates for now as there is still some functionality that needs to be ported to factors:spin-trigger-http
: client TLS,self
and service chained requestsspin-trigger-http
benchmarks