factors: Improve tests #2626
Merged
factors: Improve tests #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust analyzer doesn't like `include!`s that reach outside of a crate's own OUT_DIR: rust-lang/rust-analyzer#17040 Fix this by requiring any crate that wants expanded output (in tests) to have a build script that sets a magic env var. Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
rylev
approved these changes
Jul 11, 2024
| @@ -0,0 +1,6 @@ | |||
| fn main() { | |||
| println!("cargo::rerun-if-changed=build.rs"); | |||
There was a problem hiding this comment.
This shouldn't be necessary. build.rs is always run if changed.
There was a problem hiding this comment.
cargo-culted from https://github.com/bytecodealliance/wasmtime/blob/0e5048e20a24f6da19b3794eeb94111f052dc414/crates/component-macro/build.rs#L2
From the cargo docs:
If the build script inherently does not need to re-run under any circumstance, then emitting cargo::rerun-if-changed=build.rs is a simple way to prevent it from being re-run (otherwise, the default if no rerun-if instructions are emitted is to scan the entire package directory for changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spin-factors-deriveexpanderfeature is very useful for debugging macro output but breaks rust-analyzer due to rust-lang/rust-analyzer#17040. Fix with some annoying build script boilerplate.Also build out the WASI factor a bit, including a test.