Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Dependencies SIP #2543

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Component Dependencies SIP #2543

merged 1 commit into from
Aug 28, 2024

Conversation

fibonacci1729
Copy link
Contributor

@fibonacci1729 fibonacci1729 commented Jun 5, 2024 •
edited
Loading

This PR supersedes #1779

Rendered

@fibonacci1729 fibonacci1729 mentioned this pull request Jun 5, 2024
Closed
itowlson
itowlson reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this under way. Thank you so much for driving it Brian.

docs/content/sips/0xx-component-dependencies.md Outdated Show resolved Hide resolved
docs/content/sips/0xx-component-dependencies.md Outdated Show resolved Hide resolved
docs/content/sips/0xx-component-dependencies.md Outdated Show resolved Hide resolved
rylev
rylev reviewed Jun 6, 2024
View reviewed changes
docs/content/sips/0xx-component-dependencies.md Outdated Show resolved Hide resolved
docs/content/sips/0xx-component-dependencies.md Outdated Show resolved Hide resolved
docs/content/sips/0xx-component-dependencies.md Outdated Show resolved Hide resolved
@lann lann added the spin-3.0 label Jun 24, 2024
@fibonacci1729 fibonacci1729 mentioned this pull request Jul 26, 2024
Merged
@radu-matei radu-matei added this to the Spin 3.0 milestone Aug 20, 2024
@fibonacci1729 fibonacci1729 force-pushed the component-dependencies-sip branch 2 times, most recently from 7568d1d to e82514d Compare August 23, 2024 20:25
@fibonacci1729 fibonacci1729 force-pushed the component-dependencies-sip branch from e82514d to 2f8a4e7 Compare August 26, 2024 16:33
@fibonacci1729 fibonacci1729 mentioned this pull request Aug 27, 2024
Closed
radu-matei
radu-matei approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non blocking questions, this looks great to me, thank you!

LGTM

@fibonacci1729 fibonacci1729 force-pushed the component-dependencies-sip branch 2 times, most recently from a3bbc8c to 5a105b4 Compare August 27, 2024 22:31
@fibonacci1729 fibonacci1729 force-pushed the component-dependencies-sip branch from 5a105b4 to 0edf533 Compare August 27, 2024 22:32
@radu-matei radu-matei merged commit c02b441 into fermyon:main Aug 28, 2024
1 check passed
@fibonacci1729 fibonacci1729 deleted the component-dependencies-sip branch August 28, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelhegn mikkelhegn mikkelhegn left review comments

@radu-matei radu-matei radu-matei approved these changes

@itowlson itowlson itowlson approved these changes

@lann lann Awaiting requested review from lann

@rylev rylev Awaiting requested review from rylev

Assignees
No one assigned
Labels
spin-3.0
Projects
Spin 3.0
Status: ✅ Done
Milestone
Spin 3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@fibonacci1729 @lann @itowlson @rylev @mikkelhegn @radu-matei