Fix outbound http in the Rust SDK (take 2) #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <[email protected]>
dicej
approved these changes
Oct 27, 2023
Signed-off-by: Ryan Levick <[email protected]>
vdice
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Also fixes #1954. @vdice, the issue was that the response had a non-zero content-length header but the body was actually empty. This was fixed by actually returning the body - fixed here.
Thanks @rylev. That was the missing bit for the outbound-http-to-same-app component as well. Can we update its lib.rs to set the type as http::Response<String> in this PR as well?
Signed-off-by: Ryan Levick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of the changes from #1902.
It keeps the API for
sendthe same (with a slight change to the trait bounds). The internals are tweaked to fix outgoing requests which were not working when a body was sent.There still seems to be some bugs in wasmtime-wasi-http that prevent true streaming of outbound request bodies.
Also fixes #1954. @vdice, the issue was that the response had a non-zero content-length header but the body was actually empty. This was fixed by actually returning the body - fixed here.