Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break http crate dependency on wasmtime #1944

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

itowlson
Copy link
Contributor

I think this might be the last one folks... again I resorted to a feature but I can look at splitting out crates if people think that's better.

@itowlson itowlson requested review from lann, dicej and rylev October 25, 2023 20:49
@itowlson itowlson enabled auto-merge October 25, 2023 21:13
@itowlson itowlson merged commit 434c8ea into fermyon:main Oct 26, 2023
9 checks passed
@lann
Copy link
Collaborator

lann commented Oct 26, 2023

This is fine but I want to obnoxiously note that if there isn't something checking for this dependency it will likely creep back in.

@itowlson
Copy link
Contributor Author

@lann Yeah that's my concern. I am not sure how to mitigate it - I could put a silly check into cloud-plugin but that would be a severely lagging indicator, and Spin will never see it because it compiles app/core in anyway. I guess I could write a thingy that references the dependency-broken crates and rings a bell if it ever finds itself importing wasmtime, and include that in Spin CI. It seems awfully specific though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants