Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "duplicate package" warning when referencing Spin crates #1914

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

itowlson
Copy link
Contributor

When two Rust examples in the Spin repo have the same package name, anyone compiling Rust against any Spin repo GitHub reference - whether Spin crates or the Rust SDK - gets a "warning: skipping duplicate package ..." message.

We had another http-rust one sneak in recently: this should fix it.

@itowlson itowlson requested a review from rylev October 19, 2023 01:25
Copy link
Collaborator

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thank you!

@itowlson itowlson merged commit 55465da into fermyon:main Oct 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants