Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable loading pre-pulled OCI artifact #1874

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

jsturtevant
Copy link
Contributor

fixes #1858

@itowlson itowlson requested a review from vdice October 10, 2023 23:42
@itowlson
Copy link
Contributor

Kia ora @jsturtevant, could you run cargo fmt and cargo clippy over this please? We have those as gates in the CI.

@jsturtevant
Copy link
Contributor Author

Kia ora @jsturtevant, could you run cargo fmt and cargo clippy over this please? We have those as gates in the CI.

updated

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jsturtevant.

One last item, sorry. Can you GPG-sign the commit when convenient?

@itowlson itowlson enabled auto-merge October 11, 2023 00:40
auto-merge was automatically disabled October 11, 2023 02:04

Head branch was pushed to by a user without write access

@jsturtevant
Copy link
Contributor Author

One last item, sorry. Can you GPG-sign the commit when convenient?

np, should be updated. you actual helped me find a mis-configuraiotn in the linux dev set up that was causing it to not fully singing the commits 👍

@vdice vdice merged commit d84dde0 into fermyon:main Oct 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to load OCI with pre-fetch artifacts
3 participants