reuse sqlite connection in golang sdk #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreese
approved these changes
Oct 1, 2023
Signed-off-by: Rajat Jindal <[email protected]>
rajatjindal
force-pushed
the
reuse-sqlite-conn
branch
from
d16673d to
d04ae26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying something using golang sdk with sqlite, and kept running into "Database full" error. Turns out that error is thrown by our host component when we open too many connections to the sqlite. (separate PR incoming for that).
It seems like in our golang sdk's
Connectmethod, (which is apparently called whenever we call Execute/Query etc method), we were always opening the new connection.per the documentation of
Connectmethod, it can return a cached connection. This PR adds ability to cache and reuse the existing connection. I tested this with same app, and it works now.