Update to wasmtime 13 #1763
Update to wasmtime 13 #1763
Conversation
crates/core/src/io.rs
Outdated
|
|
||
| impl Default for OutputBuffer { | ||
| fn default() -> Self { | ||
| Self(MemoryOutputPipe::new(1024 * 1024)) |
There was a problem hiding this comment.
I don't know what this should be, but 1MB seems too small; if I'm reading this right it would cap the WAGI output size, right?
There was a problem hiding this comment.
I believe that's correct yeah. To get equivalent behavior as before you'd use usize::MAX, so that's a possibility too.
There was a problem hiding this comment.
Well it's the size of the buffer for a single write not for the entire instance, but I think we should set it to usize::MAX since that's what we effectively had before.
@lann this type doesn't seem to be used except for in tests. Would it make sense to just get rid of it?
There was a problem hiding this comment.
Oh sure enough. It used to be used by wagi but it looks like it was removed at some point. 🤷
I don't see it used anywhere else, so should be fine to remove.
rylev
force-pushed
the
update-wasmtime13
branch
4 times, most recently
from
f5ae9d8 to
f2693ca
Compare
rylev
force-pushed
the
update-wasmtime13
branch
3 times, most recently
from
c8797b2 to
533b052
Compare
Signed-off-by: Ryan Levick <[email protected]>
rylev
force-pushed
the
update-wasmtime13
branch
from
533b052 to
3628a8b
Compare
Signed-off-by: Ryan Levick <[email protected]>
Marking this as a draft until the official release of wasmtime 13.
This uses this commit off of the
release-13.0.0branch. When the wasmtime 13 release happens, we should update this to point to that release instead of this commit.This relies on two other changes:
Additionally, we need to make some decisions:
terminalinterface. We don't really track whether to given streams are the terminal or not, and some are a combination of the terminal and a file. I've done the conservative thing and marked these all asIsATTY::No, but we probably want to review that.