-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libslz: testing #2
base: master
Are you sure you want to change the base?
Conversation
Ok, I builds again, see: https://travis-ci.org/github/junghans/fedorareviews/builds/679732854, have a look at the output. As it takes the package name from the commit message it doesn't work in a pull request setting yet, but we could make that work by a.) looking a the files touch in PR and trigger on that or b.) by triggering on something else e.g. the branch name. Additionally I will write some comments about the details in the changes tab. |
echo "rpmbuild -D'_sourcedir ${H}' -D'_srcrpmdir ${H}' -bs ${H}/${PKG}.spec" | ||
echo "useradd -d ${H} -g mock review" | ||
echo "chown -R review:mock ${H}" | ||
echo "/travis/spinner.sh \"su - -c 'fedora-review -v --mock-config ${MOCK_CONFIG} -n ${PKG}' review\" || { cat ${H}/.cache/fedora-review.log; find ${H}/review-${PKG} -name '*.log' -print -exec cat {} \\;; exit 1; }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole spinner.sh
stuff there is needed as fedora-review
has no --progress
option (see https://pagure.io/FedoraReview/issue/277) and Travis just dies after 10min without output. Also fedora-review
won't print the log files if it fails.
- chmod +x review.sh | ||
- docker run --privileged -v "${PWD}:/travis:rw" -it fedora:latest /travis/review.sh | ||
|
||
after_success: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can basically ignore that whole block for now. In my setup at https://github.com/junghans/fedora-review, Travis will automatically upload the spec file,review.txt
and the src.rpm
to github.io, so one can directly paste it into a review bug.
We could do the same here, but that would need some more Travis setup, namely encrypting the private key of a deploy key with the Travis public key (Travis CLI: travis encrypt-file id_rsa.private
).
Replacement for #1 (need to enable Travis CI for this repo first)