PROMO-251(OG Plugin): Minor refinements (fs, logs) #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krakazybik
commented
Dec 23, 2021
| return { | ||
| name: "docusaurus-plugin-open-graph-image", | ||
| async postBuild({ plugins, outDir, i18n }) { | ||
| Logger.info(`OG: work in progress.`); |
There was a problem hiding this comment.
Пенерёс инициализацию в postBuild изза асинхронности.
| console.error(pc.bgRed(pc.black(`\u274C ${text}`))); | ||
| }, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Немного красивости, надеюсь никто не будет против =)
There was a problem hiding this comment.
praise: Выглядит балдежно))
Лишь бы бандл нам не расфигачило, но там разберемся уже)
|
|
||
| const { config } = initData; | ||
|
|
||
| module.exports = function (_, { templatesDir }) { |
There was a problem hiding this comment.
вернул на место удалённый по ошибке первый аргумент.
azinit
changed the title
azinit
changed the title
|
@Krakazybik Здорово что оформил отдельным PR, независимо от #375 Так рили проще будет влить 🚀 |
azinit
approved these changes
Dec 24, 2021
| @@ -11,7 +12,7 @@ function createImagePipeline(file) { | |||
| } | |||
|
|
|||
| function createImageFromTemplate({ path, name, params }) { | |||
| return createImagePipeline(`${path}\\${name}\\${params.image}`); | |||
| return createImagePipeline(resolve(path, name, params.image)); | |||
Comment on lines
+6
to
+17
| async function getConfig(configPath, encode = "utf-8") { | ||
| try { | ||
| const config = objectFromBuffer(await readFile(resolve(configPath, "config.json"), encode)); | ||
|
|
||
| if (!validateConfig(config)) { | ||
| Logger.err("Config validation error"); | ||
| return; | ||
| } | ||
|
|
||
| return config; | ||
| } catch (error) { | ||
| Logger.err(error); |
| console.error(pc.bgRed(pc.black(`\u274C ${text}`))); | ||
| }, | ||
| }; | ||
|
|
There was a problem hiding this comment.
praise: Выглядит балдежно))
Лишь бы бандл нам не расфигачило, но там разберемся уже)
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Добавлено/изменено:
Reference
#368 (review)
#251 #375
Чеклист