Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforcing that you shouldn't be able to change ids #65

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

ekryski
Copy link
Member

@ekryski ekryski commented Feb 23, 2016

It's a bad practice and as @joshuajabbour pointed out in this discussion would probably have some weird side effects. It was introduced by me in 5aaeeb4

ekryski added a commit that referenced this pull request Feb 23, 2016
enforcing that you shouldn't be able to change ids
@ekryski ekryski merged commit 27feb12 into master Feb 23, 2016
@ekryski ekryski deleted the prevent-id-changes branch February 23, 2016 21:55
@dottodot
Copy link

This change has a major downside when using a a different field for slug and pretty urls. If you want to update the slug field for seo purposes it's now impossible. I can understand the reasoning if it's the primary id field but in my case it very restrictive and unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants