Convert errorHandler to return a rejected promise instead of throwing #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup I think that should be good. |
|
Can you merge and make a patch release (error handler is only used internally so it doesn't break any public APIs)? |
ekryski
added a commit
that referenced
this pull request
Feb 23, 2016
Convert errorHandler to return a rejected promise instead of throwing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts the errorHandler to return a rejected Promise instead of throwing an error. That way everything will still work when
mongoose.Promiseisn't set to a proper Promise implementation. Otherwise the app will just crash and exit when e.g. a validation error happens.Closes #61