Traverse and change hook.data .result .query or hook.anyObj #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eddyystop
commented
Dec 12, 2016
eddyystop
commented
- Issue utility hook to trim data #37 asks for hook to trim all strings
- BestBuy/api-playground has hook to convert all strings in .query that are "null" to null. Likely used with REST HTTP transports.
- This hook can do the above and much more.
- Hook uses substack/js-traverse which is reasonable in size.
- Can use this js-traverse's get/set methods in our get/setByDot utils instead of our own code.
- Issue #37 asks for hook to trim all strings - BestBuy/api-playground has hook to convert all strings in .query that are "null" to null. Likely used with REST HTTP transports. - This hook can do the above and much more. - Uses substack/js-traverse - Can use this repo's get/set methods in our get/setByDot utils instead of our own code.
|
Looks pretty good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.