Better support for interfaces as query responses #305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide better support and documentation for how to use interfaces as query responses.
resolves #304
Description
QueryValueObject
from atype
to aninterface
.QueryValueObject
interface to the README.Motivation and context
Sometimes, specifying interfaces for query responses is preferred over types. However, custom interfaces are currently not assignable to
QueryValue
and cannot be used whereQueryValue
is required (e.g. theClient.query()
method).See #304
How was the change tested?
I added tests to demonstrate how interfaces may be used.
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.