Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaky photons in immc vessel example #76

Open
lewisfish opened this issue May 27, 2022 · 1 comment
Open

Leaky photons in immc vessel example #76

lewisfish opened this issue May 27, 2022 · 1 comment
Assignees
Labels

Comments

@lewisfish
Copy link

Hi,
On runnning demo_immc_vessel.m I get the following output which does not match the figure in the accompanying paper (fig 7 d. in Light transport modeling in highly complex tissues using the implicit mesh-based Monte Carlo algorithm).
demo_immc_vessels_fig

There are appears to be some "photon leakage" from the vessels as evidenced by the "shadow" lines emminating from the vessels.
Is this a bug in immc or just the demo script?

Best,
Lewis

@fangq fangq self-assigned this May 27, 2022
@fangq fangq added the bug label May 27, 2022
@fangq
Copy link
Owner

fangq commented May 27, 2022

@lewisfish, thanks for reporting this - I was able to reproduce the issue on my side. I went back to older versions and found that a31a85b was the last commit that did not have leakage, and the leakage was introduced in the following commit - and of course we have seen this throughout the merge process.

immc_a31a85bedb2cfef80700e6b761a0f6b5a448559e

However, I do remember there was a reason we wanted the following commit because something else wasn't working entirely. The original immc code was developed in my student @yaoruoyang's fork: https://github.com/yuanyaos/mmc/ and all original publication results were made using the code in that fork (not sure which commit).

I will take a look and see if I can figure out what has caused this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants