fix: type safety in Matrix Dart SDK database #1679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes unsafe casts - builds list using List<T>.from constructor - removes unwanted late statement Signed-off-by: The one with the braid <[email protected]>
|
Fixes: krille-chan/fluffychat#794 |
krille-chan
reviewed
Jan 15, 2024
| @@ -433,7 +434,7 @@ class MatrixSdkDatabase extends DatabaseApi { | |||
| ? timelineEventIds.getRange(start, end).toList() | |||
| : []); | |||
|
|
|||
| return await _getEventsByIds(eventIds.cast<String>(), room); | |||
| return await _getEventsByIds(eventIds, room); | |||
There was a problem hiding this comment.
This has already been fixed here: 2afd704
krille-chan
reviewed
Jan 15, 2024
| List<Map<String, dynamic>>.from( | ||
| childEntries.whereType<Map<String, dynamic>>()), | ||
| List<Map<String, dynamic>>.from( | ||
| crossSigningEntries.whereType<Map<String, dynamic>>()), |
There was a problem hiding this comment.
List<T>.from() is not better than list.cast<T>() as it crashes in the same way when there is an entry which is not T. The difference is that List<T>.from() create a non-deep copy. Do we need this here? Also this is unrelated to the bug described in the commit message
krille-chan
reviewed
Jan 15, 2024
| @@ -1489,7 +1486,7 @@ class MatrixSdkDatabase extends DatabaseApi { | |||
| try { | |||
| await clear(); | |||
| await open(); | |||
| final json = Map.from(jsonDecode(export)).cast<String, Map>(); | |||
| final json = Map<String, Map>.from(jsonDecode(export)); | |||
There was a problem hiding this comment.
Same here. This does not prevent type errors or makes anything more type safe. It just creates a non-deep copy
|
Seems to be outdated now. Please ping me if I see this wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the following premium bug report sent via matrix :