Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up clippy lints #63

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Clean up clippy lints #63

merged 3 commits into from
Sep 18, 2024

Conversation

tlater-famedly
Copy link
Contributor

No description provided.

@tlater-famedly tlater-famedly requested a review from a team as a code owner September 16, 2024 17:07
sirewix
sirewix reviewed Sep 16, 2024
View reviewed changes
tests/e2e.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

LCOV of commit 45af7c2 during Rust workflow #348

Summary coverage rate:
  lines......: 85.8% (991 of 1155 lines)
  functions..: 49.3% (231 of 469 functions)
  branches...: no data found

Files changed coverage rate:
                     |Lines       |Functions  |Branches    
  Filename           |Rate     Num|Rate    Num|Rate     Num
  =========================================================
  src/config.rs      |96.2%    209|54.1%    98|    -      0
  src/zitadel.rs     |76.7%    317|31.7%   120|    -      0

@tlater-famedly tlater-famedly force-pushed the tlater/remove-expect-used branch 2 times, most recently from 136ded6 to bae3554 Compare September 16, 2024 17:17
sirewix
sirewix previously approved these changes Sep 18, 2024
View reviewed changes
@tlater-famedly tlater-famedly force-pushed the tlater/remove-expect-used branch from 392210a to d11437c Compare September 18, 2024 10:27
@tlater-famedly
chore: Remove inline clippy::expect_used allowances in tests
d79c31a 
This is done globally with the clippy config now.
@tlater-famedly
chore: Remove outdated lint #[allow]s
b0039bd 
Seems some slipped past review.
@tlater-famedly
chore: Reduce scope of clippy lint
45af7c2 
We don't actually seem to use the `ZitadelId` for anything, but this
will likely change soon, so let's just change the lint scope.
@tlater-famedly tlater-famedly force-pushed the tlater/remove-expect-used branch from d11437c to 45af7c2 Compare September 18, 2024 10:30
@tlater-famedly tlater-famedly merged commit 45af7c2 into main Sep 18, 2024
3 checks passed
@tlater-famedly tlater-famedly deleted the tlater/remove-expect-used branch September 18, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emgrav emgrav emgrav approved these changes

@sirewix sirewix sirewix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlater-famedly @emgrav @sirewix