Skip to content

Commit

Permalink
doc: Update README
Browse files Browse the repository at this point in the history
  • Loading branch information
tlater-famedly committed Dec 5, 2024
1 parent 28bd8b6 commit 519ddba
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
9 changes: 3 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,14 @@ kubectl create configmap --from-file config.yaml famedly-sync --namespace ldap-s

## Quirks & Edge Cases

- When Setting up SSO, note that Zitadel's ldap filter must be
configured to resolve the "username" as the user's email address for
our IDP links to work.
- Changing a user's LDAP id (the attribute from the `user_id` setting)
is unsupported, as this is used to identify the user on the Zitadel
end.
- Disabling a user on the LDAP side (with `status`) results in the
user being deleted from Zitadel.
- Providing multiple values for an LDAP attribute is not supported.
- Zitadel's API is not fully atomic; if a request fails, a user may
not be fully created and still not be functional even if the tool is
re-used.
- In particular, the matrix localpart, the preferred user name, and
whether the user has permissions to use Famedly may not be synced.
- If a user's email or phone number changes, they will only be
prompted to verify it if the tool is configured to make users verify
them.
Expand Down
1 change: 0 additions & 1 deletion src/zitadel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ impl Zitadel {
.context("Failed to set IDP user ID")?,
)
.with_idp_id(self.zitadel_config.idp_id.clone())
// TODO: Figure out if this is the correct value; empty is not permitted
.with_user_name(imported_user.email.clone())]);
}

Check warning on line 172 in src/zitadel.rs

View check run for this annotation

Codecov / codecov/patch

src/zitadel.rs#L172

Added line #L172 was not covered by tests

Expand Down

0 comments on commit 519ddba

Please sign in to comment.