-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(eslint): limit usage of globals in src #3191
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3191 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2798 2798
Lines 227335 227335
Branches 958 957 -1
==========================================
- Hits 227268 227260 -8
- Misses 67 75 +8
|
What happened to the original implementation where globals that are not specific to an environment were allowed? |
It was never added to our source and this solution was recommended to me by members of eslint. |
Also AFAIK we don't actually want to use any additional globals anyway. |
Fixes #3145
Ban the usage of globals in our
src
folder.All usages of these globals have to be marked with a eslint disable rule making them easier to spot.