Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: update file structure for util/internal #3141

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

  • Moved generateMersenne*Randomizers() from src/internal/mersenne.ts functions to the src/utils directory.
  • Moved src/utils/types.ts to the src/internal directory.
  • Moved src/locale-proxy.ts to src/internal directory.
  • Updated the test directory to mimic the new position of files

Closes #2961. Continuation of #2964.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Sep 24, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Sep 24, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team September 24, 2024 17:45
@xDivisionByZerox xDivisionByZerox self-assigned this Sep 24, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner September 24, 2024 17:45
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 7898018
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66f3018ce0c7300008b13a67
😎 Deploy Preview https://deploy-preview-3141.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (424b120) to head (7898018).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3141      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2776     2777       +1     
  Lines      226341   226342       +1     
  Branches      944      943       -1     
==========================================
- Hits       226275   226273       -2     
- Misses         66       69       +3     
Files with missing lines Coverage Δ
src/faker.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <ø> (ø)
src/internal/locale-proxy.ts 100.00% <100.00%> (ø)
src/internal/mersenne.ts 94.03% <ø> (-1.05%) ⬇️
src/internal/types.ts 100.00% <ø> (ø)
src/modules/date/index.ts 100.00% <100.00%> (ø)
src/modules/string/index.ts 100.00% <ø> (ø)
src/simple-faker.ts 100.00% <100.00%> (ø)
src/utils/mersenne.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT merged commit 9537dfd into next Sep 26, 2024
23 checks passed
@ST-DDT ST-DDT deleted the infa/update-architecture-for-util branch September 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move utils to the correct place
3 participants