-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): implement more colors to pt_PT locale #3021
Merged
xDivisionByZerox
merged 3 commits into
faker-js:next
from
jeanpierrecarvalho:jpcarvalho/feat/implement-more-pt-pt-colors
Aug 15, 2024
Merged
feat(locale): implement more colors to pt_PT locale #3021
xDivisionByZerox
merged 3 commits into
faker-js:next
from
jeanpierrecarvalho:jpcarvalho/feat/implement-more-pt-pt-colors
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3021 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2772 2772
Lines 226182 226221 +39
Branches 943 942 -1
==========================================
+ Hits 226125 226154 +29
- Misses 57 67 +10
|
Shinigami92
approved these changes
Jul 16, 2024
ST-DDT
added
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
m: color
Something is referring to the color module
labels
Jul 16, 2024
ST-DDT
approved these changes
Jul 16, 2024
ST-DDT
changed the title
feat: implement more colors to pt_PT locale
feat(locale): implement more colors to pt_PT locale
Jul 16, 2024
xDivisionByZerox
approved these changes
Jul 20, 2024
import-brain
approved these changes
Jul 24, 2024
This is scheduled for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
m: color
Something is referring to the color module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3021: Addition of More Colors to pt_PT Locale
Changes Made:
Details of Changes:
Additional Details:
The additions were made to enhance the localization and ensure a comprehensive representation of color names in Portuguese.