-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PathLike objects in base_path #2206
Conversation
This enables this usage in MkDocs (note that specifying as a list already works): ```yml - pymdownx.snippets: base_path: !relative $docs_dir ``` Currently you get an error: ``` self.base_path = [os.path.abspath(b) for b in base] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: 'DocsDirPlaceholder' object is not iterable ```
We would need tests to confirm that things are working with PathLike objects. |
Can you enable |
Hmm, it may not be necessary to enable |
So does anything need to be changed? I understood this as probably not? |
No, I think it is fine, thanks for checking back in. |
@gir-bot lgtm |
This enables this usage in MkDocs (note that specifying as a list already works):
Currently you get an error: