-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
result from marching_cubes
has identical vertex indices
#1731
Comments
Khoa-NT
referenced
this issue
Feb 13, 2024
Summary: Fixes #1641. The bug was caused by the mistaken downcasting of an int64_t into int, causing issues only on inputs large enough to have hashes that escaped the bounds of an int32. Also added a test case for this issue. Reviewed By: bottler Differential Revision: D53505370 fbshipit-source-id: 0fdd0efc6d259cc3b0263e7ff3a4ab2c648ec521
I have the same problem on |
facebook-github-bot
pushed a commit
that referenced
this issue
Mar 7, 2024
Summary: Fix an inclusive vs exclusive scan mix-up that was accidentally introduced when removing the Thrust dependency (`Thrust::exclusive_scan`) and reimplementing it using `at::cumsum` (which does an inclusive scan). This fixes two Github reported issues: * #1731 * #1751 Reviewed By: bottler Differential Revision: D54605545 fbshipit-source-id: da9e92f3f8a9a35f7b7191428d0b9a9ca03e0d4d
I believe this to be fixed by 7566530, I ran your repro locally and it succeeded. Do let me know if it's still broken for you. Thanks! |
I can confirm this is working again on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bugs / Unexpected behaviors
The result from marching_cubes on GPU is not correct
Instructions To Reproduce the Issue:
pytorch3D installed from commit c292c71
Previous test result is in #1641 (comment)
View from meshlab
1) Run on CPU with marching_cubes_naive
2) Run on CPU with marching_cubes
3) Run on CUDA with marching_cubes
The text was updated successfully, but these errors were encountered: