Skip to content

Commit

Permalink
Bug-fix visualize reconstruction
Browse files Browse the repository at this point in the history
Summary:
Addresses the following issue:
#1345 (comment)

I.e., when installed from conda, `pytorch3d_implicitron_visualizer` crashes since it invokes `main()` while `main` requires a single positional arg `argv`.

Reviewed By: shapovalov

Differential Revision: D41533497

fbshipit-source-id: e53a923eb8b2f0f9c0e92e9c0866d9cb310c4799
  • Loading branch information
davnov134 authored and facebook-github-bot committed Nov 25, 2022
1 parent 60ab1cd commit c3a6ab0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions projects/implicitron_trainer/visualize_reconstruction.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def _get_config_from_experiment_directory(experiment_directory) -> DictConfig:
return OmegaConf.merge(get_default_args(Experiment), config)


def main(argv) -> None:
def main(argv=sys.argv) -> None:
# automatically parses arguments of visualize_reconstruction
cfg = OmegaConf.create(get_default_args(visualize_reconstruction))
cfg.update(OmegaConf.from_cli(argv))
Expand All @@ -150,4 +150,4 @@ def main(argv) -> None:


if __name__ == "__main__":
main(sys.argv)
main()

0 comments on commit c3a6ab0

Please sign in to comment.