pulsar image size bug fix

Summary: Small change to swap how height/width are inferred from the image_size setting. Reviewed By: gkioxari Differential Revision: D26648340 fbshipit-source-id: 2c657a115c96cadf3ac63be87b0e1bfba10c9315
facebookresearch · Feb 26, 2021 · 4bb3fff · 4bb3fff
1 parent 9c161d1
commit 4bb3fff
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/docs/examples/pulsar_basic_unified.py b/docs/examples/pulsar_basic_unified.py
@@ -56,12 +56,12 @@ def cli():
         focal_length=(5.0 * 2.0 / 2.0,),
         R=torch.eye(3, dtype=torch.float32, device=device)[None, ...],
         T=torch.zeros((1, 3), dtype=torch.float32, device=device),
-        image_size=((width, height),),
+        image_size=((height, width),),
         device=device,
     )
     vert_rad = torch.rand(n_points, dtype=torch.float32, device=device)
     raster_settings = PointsRasterizationSettings(
-        image_size=(width, height),
+        image_size=(height, width),
         radius=vert_rad,
     )
     rasterizer = PointsRasterizer(cameras=cameras, raster_settings=raster_settings)

diff --git a/docs/examples/pulsar_cam_unified.py b/docs/examples/pulsar_cam_unified.py
@@ -123,11 +123,11 @@ def __init__(self):
             focal_length=self.focal_length,
             R=self.cam_rot[None, ...],
             T=self.cam_pos[None, ...],
-            image_size=((WIDTH, HEIGHT),),
+            image_size=((HEIGHT, WIDTH),),
             device=DEVICE,
         )
         raster_settings = PointsRasterizationSettings(
-            image_size=(WIDTH, HEIGHT),
+            image_size=(HEIGHT, WIDTH),
             radius=self.vert_rad,
         )
         rasterizer = PointsRasterizer(

diff --git a/docs/examples/pulsar_optimization_unified.py b/docs/examples/pulsar_optimization_unified.py
@@ -84,11 +84,11 @@ def __init__(self):
             focal_length=5.0,
             R=torch.eye(3, dtype=torch.float32, device=DEVICE)[None, ...],
             T=torch.zeros((1, 3), dtype=torch.float32, device=DEVICE),
-            image_size=((WIDTH, HEIGHT),),
+            image_size=((HEIGHT, WIDTH),),
             device=DEVICE,
         )
         raster_settings = PointsRasterizationSettings(
-            image_size=(WIDTH, HEIGHT),
+            image_size=(HEIGHT, WIDTH),
             radius=self.vert_rad,
         )
         rasterizer = PointsRasterizer(

diff --git a/pytorch3d/renderer/points/pulsar/unified.py b/pytorch3d/renderer/points/pulsar/unified.py
@@ -80,7 +80,7 @@ def __init__(
                 "by the pulsar backend."
             )
         if isinstance(rasterizer.raster_settings.image_size, tuple):
-            width, height = rasterizer.raster_settings.image_size
+            height, width = rasterizer.raster_settings.image_size
         else:
             width = rasterizer.raster_settings.image_size
             height = rasterizer.raster_settings.image_size