Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ntrace patch to third-party (exclude ext_tag) #4

Closed
wants to merge 3 commits into from

Conversation

minsii
Copy link

@minsii minsii commented Sep 16, 2022

Summary:
Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang [email protected]

Reviewed By: kingchc

Differential Revision: D38637718

facebook-github-bot and others added 2 commits August 25, 2022 10:50
Co-authored-by: Facebook Community Bot <[email protected]>
fbshipit-source-id: 6939f9f252d3048c174c7cacabcc15f921b6096c
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D38637718

minsii added a commit to minsii/nccl that referenced this pull request Sep 22, 2022
Summary:
Pull Request resolved: facebookresearch#4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: 94f8dd163df18cd6fe4e4abc811570cb159b876f
@minsii minsii force-pushed the export-D38637718-to-exp branch from 435e40a to 38e738a Compare September 22, 2022 21:30
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D38637718

Summary:
Pull Request resolved: facebookresearch#4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: d689a31f2525bd423c9e87671b9fc8ddabb2835a
@minsii minsii force-pushed the export-D38637718-to-exp branch from 38e738a to 2ea9277 Compare October 7, 2022 04:51
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D38637718

facebook-github-bot pushed a commit that referenced this pull request Oct 8, 2022
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Oct 21, 2022
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Oct 21, 2022
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Oct 24, 2022
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
spease-fb pushed a commit to spease-fb/nccl that referenced this pull request Dec 21, 2022
Summary:
Pull Request resolved: facebookresearch#4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
spease-fb pushed a commit to spease-fb/nccl that referenced this pull request Dec 21, 2022
Summary:
Pull Request resolved: facebookresearch#4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Mar 4, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Mar 4, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Mar 4, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Mar 6, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Apr 24, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Apr 24, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request Apr 24, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request May 10, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request May 10, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
spease-fb pushed a commit to spease-fb/nccl that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: facebookresearch#4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
spease-fb pushed a commit to spease-fb/nccl that referenced this pull request May 12, 2023
Summary:
Pull Request resolved: facebookresearch#4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
kingchc pushed a commit that referenced this pull request May 12, 2023
Summary:
Pull Request resolved: #4

Introduce ntrace into NCCL to trace important IB events per collective communication. It requires a separate module ntrace_rt to enable in Makefile based build. For now, ENABLE_NTRACE is always off when building from Makefile.

Co-author: Xianghuai Zhang <[email protected]>

Reviewed By: kingchc

Differential Revision: D38637718

fbshipit-source-id: aca15a9297f175aac873dbfffef3845fcd596b87
@minsii minsii deleted the branch facebookresearch:exp July 25, 2023 02:01
@minsii minsii closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants