Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] hotfixes to OSS Readme #94

Merged
merged 1 commit into from
Sep 17, 2020
Merged

[bug] hotfixes to OSS Readme #94

merged 1 commit into from
Sep 17, 2020

Conversation

blefaudeux
Copy link
Contributor

@blefaudeux blefaudeux commented Sep 17, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes a missing import and a broken link. Related to #63

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2020
@blefaudeux blefaudeux requested a review from msbaines September 17, 2020 19:28
@blefaudeux blefaudeux merged commit 656828b into master Sep 17, 2020
@blefaudeux blefaudeux deleted the readme_hotfix branch September 17, 2020 19:30
myleott added a commit that referenced this pull request Feb 22, 2021
@myleott
Add ReduceScatterBucketer (#94)
77dc364 
* Add ReduceScatterBucketer

* Add test

* Move chunk_and_pad to fairscale.utils.parallel and add tests

* Iterate on tests

* CR comments

* more

* Remove most tests to speed up CI iteration cycle

* Fix for Python < 3.8

* more

* Revert "Remove most tests to speed up CI iteration cycle"

This reverts commit a1981ae496b021a767fbf411f95840c55fad8d17.

* CR

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@min-xu-ai min-xu-ai Awaiting requested review from min-xu-ai

@msbaines msbaines Awaiting requested review from msbaines

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blefaudeux @facebook-github-bot