Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] fix pre-commit mypy issues #87

Merged
merged 1 commit into from
Sep 16, 2020
Merged

[cleanup] fix pre-commit mypy issues #87

merged 1 commit into from
Sep 16, 2020

Conversation

msbaines
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2020
@blefaudeux
Copy link
Contributor

LGTM !

@msbaines msbaines merged commit 4a874a6 into master Sep 16, 2020
@msbaines msbaines deleted the mypy-fix branch September 16, 2020 17:14
myleott pushed a commit that referenced this pull request Feb 22, 2021
* adding TrainingState enum for asserting purpose

* addressed Sam's suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants