[feat ] OSS : optional closure argument for the optimizer #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
blefaudeux
commented
Sep 14, 2020
| loss = self.optim.step(closure=closure, **kwargs) # type: ignore | ||
| # Run the optimizer step on this shard only: | ||
| if self._pass_closure: | ||
| loss = self.optim.step(closure=closure, **kwargs) # type: ignore |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
blefaudeux
changed the title
msbaines
approved these changes
Sep 15, 2020
myleott
pushed a commit
that referenced
this pull request
Feb 22, 2021
- this way, it is slightly easier to run all tests by python -m pytest tests/nn/data_parallel/test_fsdp*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #81. In short the closure keyword is optional for pytorch optimizer's, but OSS made it mandatory. nVidia's LARC does not support the closure keyword, so we broke down on them. This PR fixes it by checking once at runtime whether this optimizer supports the closure keyword.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃