Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] FSDP: add the failing test for #421 #453

Merged
merged 4 commits into from
Mar 1, 2021
Merged

[test] FSDP: add the failing test for #421 #453

merged 4 commits into from
Mar 1, 2021

Conversation

min-xu-ai
Copy link
Contributor

What does this PR do?

first step for # (issue). Thanks @SeanNaren for contributing the test!

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2021
@min-xu-ai min-xu-ai merged commit 5ecac15 into master Mar 1, 2021
@min-xu-ai min-xu-ai deleted the min/test branch March 1, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants