Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatize the sharded optimizer within the sharded DDP #91

Closed
blefaudeux opened this issue Sep 16, 2020 · 0 comments · Fixed by #97
Closed

Privatize the sharded optimizer within the sharded DDP #91

blefaudeux opened this issue Sep 16, 2020 · 0 comments · Fixed by #97
Assignees

Comments

@blefaudeux
Copy link
Contributor

🚀 Feature

Align the OSS_ddp architecture with this proposal pytorch/pytorch#42849.
A main difference is that oss_ddp owns the construction of the sharded optimizer, it does not have to be exposed.

Motivation

  • Prototype something closer to the RFC
  • Bring the sharding in the same place, so that we can eventually align the sharding from the optimizer and the model parameter sharding. Right now DDP gets the full model

Pitch

Keep backward compatibilty: using OSS directly stays possible, but if targeting oss_ddp, then it owns the sharded optimizer. Eventually surface the sharding and align both

Alternatives

Keep the current approach in two seperate steps (shard DDP / shard optim), but it does not seem very future proof

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant