Mutox classifier #44

David-OC17 · 2024-10-26T02:54:21Z

Elements to include in PR

Migrate Mutox code from Seamless Communication
Add unit tests for the pipeline
(Optional) add softmax computation on top of classifier

Note: A follow-up PR will be needed in the Seamless Communication repository to account for the migration being made here.

examples/mutox_example.ipynb

mutox/__init__.py

mutox/speech_pipeline.py

pyproject.toml

mutox/cli/README.md

tests/unit_tests/test_mutox.py

sonar/models/mutox/classifier.py

sonar/models/mutox/builder.py

sonar/models/mutox/classifier.py

sonar/inference_pipelines/mutox_speech.py

README.md

examples/mutox_example.ipynb

README.md

…repo decoupling, other

README.md

sonar/cards/sonar_mutox.yaml

sonar/models/mutox/classifier.py

sonar/inference_pipelines/mutox_speech.py

… linter/mypy related

sonar/models/mutox/classifier.py

tests/unit_tests/test_mutox.py

…other related changes

avidale

Looks good to me!
Let's fix the rest of the mypy tests and maybe come up with an example of a more toxic sentence, and we are done.

tests/integration_tests/test_mutox.py

tests/unit_tests/test_mutox.py

…erage, other changes to satisfy mypy

David-OC17 · 2024-11-23T03:04:42Z

Got it down to that one mypy error, cannot solve it still.

avidale · 2024-11-25T16:53:24Z

Got it down to that one mypy error, cannot solve it still.

If you absolutely cannot, I think, it is fine to tell Mypy just to ignore this error (by adding a comment # type: ignore on the corresponding line).

David-OC17 added 2 commits October 25, 2024 19:24

Main code transfer of Mutox classifier from SeamlessM4T

eff7989

Minor changes, import inside mutox broken

822673a

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2024

David-OC17 commented Oct 26, 2024

View reviewed changes

examples/mutox_example.ipynb Outdated Show resolved Hide resolved

avidale reviewed Oct 28, 2024

View reviewed changes

mutox/__init__.py Outdated Show resolved Hide resolved

mutox/speech_pipeline.py Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

mutox/cli/README.md Outdated Show resolved Hide resolved

mutox/cli/README.md Outdated Show resolved Hide resolved

David-OC17 added 2 commits October 28, 2024 19:02

Corrections from PR facebookresearch#44 comments

35c9175

Added unit tests for mutox builder, classifier

60f1816

David-OC17 requested a review from avidale October 29, 2024 02:00

artemru reviewed Oct 29, 2024

View reviewed changes

tests/unit_tests/test_mutox.py Show resolved Hide resolved

artemru reviewed Oct 29, 2024

View reviewed changes

sonar/models/mutox/classifier.py Outdated Show resolved Hide resolved

artemru reviewed Oct 29, 2024

View reviewed changes

sonar/models/mutox/builder.py Show resolved Hide resolved

avidale reviewed Oct 29, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

Resolved comments PR#44: Added MutoxConfig opt layer, style changes, …

55a342d

…repo decoupling, other

David-OC17 force-pushed the mutox_classifier branch from ed55f21 to 55a342d Compare November 9, 2024 00:13

avidale reviewed Nov 13, 2024

View reviewed changes

David-OC17 added 2 commits November 20, 2024 03:21

Resolved comments 2 PR#44: Missing comments, style changes, others

d2d7d60

Resolved comments 3 PR#44: opt sigmoid layer change, card edit, other…

1baaf49

… linter/mypy related

David-OC17 force-pushed the mutox_classifier branch from f5add3f to 1baaf49 Compare November 20, 2024 11:22

avidale requested changes Nov 21, 2024

View reviewed changes

sonar/models/mutox/classifier.py Outdated Show resolved Hide resolved

tests/unit_tests/test_mutox.py Show resolved Hide resolved

avidale marked this pull request as ready for review November 21, 2024 09:12

avidale reviewed Nov 21, 2024

View reviewed changes

tests/unit_tests/test_mutox.py Show resolved Hide resolved

Resolved comments 4 PR#44

96f5d6f

David-OC17 force-pushed the mutox_classifier branch from a126f2d to 3bfd1b3 Compare November 21, 2024 23:14

David-OC17 requested a review from avidale November 21, 2024 23:15

Resolved comments 5 PR#44: new integration and unit tests for mutox, …

7c3b3f9

…other related changes

David-OC17 force-pushed the mutox_classifier branch from 3bfd1b3 to 7c3b3f9 Compare November 21, 2024 23:18

avidale approved these changes Nov 22, 2024

View reviewed changes

tests/integration_tests/test_mutox.py Show resolved Hide resolved

tests/unit_tests/test_mutox.py Show resolved Hide resolved

Resolved comments 6 PR#44: modifying integration test to increase cov…

8de0914

…erage, other changes to satisfy mypy

Added line #type: ignore to pass mypy check

9648d9d

David-OC17 force-pushed the mutox_classifier branch from ca1fc7d to 9648d9d Compare December 4, 2024 15:53

avidale merged commit a914bbd into facebookresearch:main Dec 4, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mutox classifier #44

Mutox classifier #44

David-OC17 commented Oct 26, 2024

avidale left a comment

David-OC17 commented Nov 23, 2024

avidale commented Nov 25, 2024 •

edited

Loading

Mutox classifier #44

Mutox classifier #44

Conversation

David-OC17 commented Oct 26, 2024

Elements to include in PR

avidale left a comment

Choose a reason for hiding this comment

David-OC17 commented Nov 23, 2024

avidale commented Nov 25, 2024 • edited Loading

avidale commented Nov 25, 2024 •

edited

Loading