TypeGraph: Rename visit(Type) functions to accept(Type) #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visit(Type&) and visit(Type*) were helper functions than did cycle detection and provided nicer syntax for the type.accept(*this) calls. However, because they overloaded the visit() function, it was easy to accidentally call a concrete visit method (e.g. visit(Class&)) instead of the virtual-dispatching visit(Type&). By changing the name of this wrapper, it will make it much more obvious when code is introduced which bypasses the cycle detection.
JakeHillion
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visit(Type&)andvisit(Type*)were helper functions than did cycle detection and provided nicer syntax for thetype.accept(*this)calls.However, because they overloaded the
visit()function, it was easy to accidentally call a concrete visit method (e.g.visit(Class&)) instead of the virtual-dispatchingvisit(Type&).By changing the name of this wrapper, it will make it much more obvious when code is introduced which bypasses the cycle detection.