Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: Remove unnecessary make_unique calls #205

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

ajor
Copy link
Contributor

@ajor ajor commented Jul 4, 2023

This was a purely mechanical change made with some find-and-replace macros. The tests still pass afterwards.

The second commit I'm bundling into this PR is a lot smaller and just moves the last remaining tests onto using the type_graph_utils helpers.

ajor added 2 commits July 4, 2023 08:55
This was a purely mechanical change made with some find-and-replace
macros.
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #205 (8ed7fa7) into main (01c9573) will decrease coverage by 0.05%.
The diff coverage is 97.35%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   65.01%   64.97%   -0.05%     
==========================================
  Files          87       87              
  Lines        9487     9478       -9     
  Branches     1568     1568              
==========================================
- Hits         6168     6158      -10     
  Misses       2486     2486              
- Partials      833      834       +1     
Impacted Files Coverage Δ
test/test_add_padding.cpp 91.66% <88.88%> (ø)
test/test_flattener.cpp 95.03% <95.45%> (ø)
test/test_alignment_calc.cpp 97.29% <96.55%> (-0.21%) ⬇️
test/test_name_gen.cpp 99.15% <100.00%> (-0.02%) ⬇️
test/test_remove_top_level_pointer.cpp 100.00% <100.00%> (ø)
test/test_topo_sorter.cpp 99.14% <100.00%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ajor ajor merged commit 5560624 into facebookexperimental:main Jul 4, 2023
@ajor ajor deleted the update-tests branch July 4, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants