Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer: Improvements for displaying large type graphs #176

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

ajor
Copy link
Contributor

@ajor ajor commented Jun 23, 2023

  • Don't truncate output above 30k characters
  • Include enough padding at the begining of lines to account for large node IDs

Before:

[1070]                       Class: ClassName
                            Param                                                                                                                                                                                                                                                                                                          
                              Enum: ParamName (size: 4)

After:

[1070]                       Class: ClassName
                               Param                                                                                                                                                                                                                                                                                                       
                                 Enum: ParamName (size: 4)

ajor added 2 commits June 23, 2023 06:32
- Don't truncate output above 30k characters
- Include enough padding at the begining of lines to account for large
  node IDs
@codecov-commenter
Copy link

Codecov Report

Merging #176 (55b5e82) into main (02b7641) will decrease coverage by 0.07%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   62.58%   62.52%   -0.07%     
==========================================
  Files          88       87       -1     
  Lines        9243     9227      -16     
  Branches     1529     1527       -2     
==========================================
- Hits         5785     5769      -16     
  Misses       2641     2641              
  Partials      817      817              
Impacted Files Coverage Δ
test/test_add_padding.cpp 91.66% <ø> (ø)
test/test_remove_ignored.cpp 96.66% <ø> (ø)
test/test_type_identifier.cpp 90.62% <ø> (ø)
test/test_flattener.cpp 95.83% <50.00%> (-0.17%) ⬇️
oi/type_graph/PassManager.cpp 100.00% <100.00%> (ø)
oi/type_graph/Printer.cpp 97.10% <100.00%> (+0.13%) ⬆️
oi/type_graph/TypeGraph.h 100.00% <100.00%> (ø)
test/test_drgn_parser.cpp 98.98% <100.00%> (ø)
test/test_remove_top_level_pointer.cpp 100.00% <100.00%> (ø)
test/type_graph_utils.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ajor ajor merged commit 6dce2d1 into facebookexperimental:main Jun 23, 2023
@ajor ajor deleted the printer-improvements branch June 23, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants