Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattener: Attempt to take params from parent allocator in case of bad DWARF #172

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

ajor
Copy link
Contributor

@ajor ajor commented Jun 20, 2023

This is needed for running tests in CI, as the older compilers we have there generate bad DWARF with missing template parameters for allocators.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #172 (5316ee3) into main (02b7641) will increase coverage by 0.25%.
The diff coverage is 91.02%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   62.58%   62.84%   +0.25%     
==========================================
  Files          88       88              
  Lines        9243     9318      +75     
  Branches     1529     1536       +7     
==========================================
+ Hits         5785     5856      +71     
+ Misses       2641     2640       -1     
- Partials      817      822       +5     
Impacted Files Coverage Δ
oi/type_graph/Printer.h 100.00% <ø> (ø)
oi/CodeGen.cpp 38.46% <50.00%> (ø)
oi/type_graph/TypeIdentifier.cpp 88.00% <66.66%> (+1.33%) ⬆️
oi/type_graph/Printer.cpp 96.47% <90.00%> (-0.50%) ⬇️
test/test_type_identifier.cpp 92.53% <94.28%> (+1.91%) ⬆️
test/test_codegen.cpp 95.34% <95.65%> (+0.34%) ⬆️
oi/EnumBitset.h 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ajor ajor force-pushed the type-graph-allocator-params branch from f06c2fd to 5316ee3 Compare June 23, 2023 13:24
@ajor ajor marked this pull request as ready for review June 23, 2023 13:24
@ajor ajor marked this pull request as draft June 23, 2023 14:04
@ajor
Copy link
Contributor Author

ajor commented Jun 23, 2023

This causes some problems - see failures on #161. Needs a different approach.

@ajor ajor force-pushed the type-graph-allocator-params branch 2 times, most recently from 110bf25 to 0792de3 Compare June 26, 2023 15:08
@ajor ajor changed the title TypeIdentifier: Attempt to take params from parent allocator in case of bad DWARF Flattener: Attempt to take params from parent allocator in case of bad DWARF Jun 26, 2023
@ajor
Copy link
Contributor Author

ajor commented Jun 26, 2023

Reworked to have Flattener do most of the work

@ajor ajor force-pushed the type-graph-allocator-params branch from 0792de3 to 5a9d58a Compare June 26, 2023 15:30
@ajor ajor marked this pull request as ready for review June 26, 2023 15:35
oi/type_graph/Flattener.cpp Show resolved Hide resolved
@ajor ajor merged commit 1bb0c62 into facebookexperimental:main Jun 27, 2023
@ajor ajor deleted the type-graph-allocator-params branch June 27, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants